Improve page loading performance #18389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elega
force-pushed
the
yimin/fix-cold-read-preloading
branch
from
f058275
to
2f11561
Compare
dbw9580
reviewed
Nov 8, 2023
| try { | ||
| return mRpcFutureStub.withDeadlineAfter(mRpcTimeoutMs, TimeUnit.MILLISECONDS) | ||
| return mRpcBlockingStub.withDeadlineAfter(mRpcTimeoutMs, TimeUnit.MILLISECONDS) |
There was a problem hiding this comment.
why changed to a blocking implementation?
There was a problem hiding this comment.
we want to make sure the first call finishes before sending the second call other the tasks in the worker queue will be disordered.
There was a problem hiding this comment.
in that case you can instead wait on the returned future instead of making it blocking.
| @@ -75,13 +75,13 @@ public void put(PageId pageId, | |||
| Path parent = Preconditions.checkNotNull(pagePath.getParent(), | |||
| "parent of cache file should not be null"); | |||
| Files.createDirectories(parent); | |||
| Files.createFile(pagePath); | |||
| //Files.createFile(pagePath); | |||
There was a problem hiding this comment.
this can be removed instead of commneted out
elega
added
the
type-performance
|
alluxio-bot, merge this please. |
|
alluxio-bot, cherry-pick this to branch-3-1.1.x please. |
alluxio-bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
### What changes are proposed in this pull request? Improve page loading performance by loading the page form UFS directly, instead of creating a reader. ### Why are the changes needed? To improve the data loading performance & reduce the memory consumption ### Does this PR introduce any user facing changes? N/A pr-link: #18389 change-id: cid-46e89dcfd22dcbbb4090df7f6c8861408ef8cb67
|
Auto cherry-pick to branch |
huanghua78
reviewed
Nov 13, 2023
dora/core/server/worker/src/main/java/alluxio/worker/dora/PagedDoraWorker.java
Show resolved
Hide resolved
ssz1997
pushed a commit
to ssz1997/alluxio
that referenced
this pull request
Dec 15, 2023
### What changes are proposed in this pull request? Improve page loading performance by loading the page form UFS directly, instead of creating a reader. ### Why are the changes needed? To improve the data loading performance & reduce the memory consumption ### Does this PR introduce any user facing changes? N/A pr-link: Alluxio#18389 change-id: cid-46e89dcfd22dcbbb4090df7f6c8861408ef8cb67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Improve page loading performance by loading the page form UFS directly, instead of creating a reader.
Why are the changes needed?
To improve the data loading performance & reduce the memory consumption
Does this PR introduce any user facing changes?
N/A