Use generic Exception to catch all exceptions in getStatus() #18398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print file path in getStatus() exception on client side Signed-off-by: Huang Hua <huanghua78@msn.com>
Signed-off-by: Huang Hua <huanghua78@msn.com>
|
alluxio-bot, merge this please. |
|
merge failed: |
|
alluxio-bot, merge this please. |
ssz1997
pushed a commit
to ssz1997/alluxio
that referenced
this pull request
Dec 15, 2023
Also print file path in getStatus() exception on client side ### What changes are proposed in this pull request? Use generic Exception to catch all exceptions in getStatus(), just like that in all other handlers. File path will be included in log message for getStatus(). ### Why are the changes needed? Sometimes, exceptions are thrown in under file system and/or other third-party libraries. We don't know the exact type of the specific exceptions. If they are not caught, client will report unknown exceptions in logs. This is misleading. ### Does this PR introduce any user facing changes? Client will show logs with detailed exception information if there is any. For getStatus(), file path will also be shown in log. pr-link: Alluxio#18398 change-id: cid-b6acee3dd0c3e2e03e66bbf195cbda1e95f6bf64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also print file path in getStatus() exception on client side
What changes are proposed in this pull request?
Use generic Exception to catch all exceptions in getStatus(), just like that in all other handlers.
File path will be included in log message for getStatus().
Why are the changes needed?
Sometimes, exceptions are thrown in under file system and/or other third-party libraries.
We don't know the exact type of the specific exceptions. If they are not caught, client will
report unknown exceptions in logs. This is misleading.
Does this PR introduce any user facing changes?
Client will show logs with detailed exception information if there is any.
For getStatus(), file path will also be shown in log.