Remove malformed empty page files on access #18401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beinan
approved these changes
Nov 9, 2023
dbw9580
commented
Nov 9, 2023
dora/core/client/fs/src/main/java/alluxio/client/file/cache/store/LocalPageStore.java
Show resolved
Hide resolved
dbw9580
commented
Nov 9, 2023
dora/core/client/fs/src/main/java/alluxio/client/file/cache/store/LocalPageStore.java
Show resolved
Hide resolved
|
alluxio-bot, merge this please |
ssz1997
pushed a commit
to ssz1997/alluxio
that referenced
this pull request
Dec 15, 2023
### What changes are proposed in this pull request? Remove empty pages when they are accessed by the get page methods. Empty pages except for the vert first page of a file are most likely malformed and are a result of a failed put attempt. ### Why are the changes needed? Reading empty pages causes 0 bytes to be read, and in some cases causing an infinite loop in the caller. When used with `getDataFileChannel`, it results in the channel to be created multiple times for a given empty page, because the channels are always 0 sized. ### Does this PR introduce any user facing changes? No. pr-link: Alluxio#18401 change-id: cid-fff8f48af3814e3c71317377aa0b065599c06a57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Remove empty pages when they are accessed by the get page methods. Empty pages except for the vert first page of a file are most likely malformed and are a result of a failed put attempt.
Why are the changes needed?
Reading empty pages causes 0 bytes to be read, and in some cases causing an infinite loop in the caller. When used with
getDataFileChannel, it results in the channel to be created multiple times for a given empty page, because the channels are always 0 sized.Does this PR introduce any user facing changes?
No.