Fix etcd calls exception handling and adjust failure detection timeout #18554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when refresh the workers view instead of propagate throwing all the way to the caller 2. make worker failure detection timeout (the timeout to determine if a worker is in FAILED state) configurable thru setting the service discovery entity's lease ttl 3. make newLeaseInternal always overwrite the key with the newly created lease
…KER_FAILURE_TIMEOUT_IN_MILLIS
JiamingMai
approved these changes
Mar 27, 2024
Kai-Zhang
approved these changes
Mar 28, 2024
| @@ -68,11 +74,11 @@ public class MembershipManagerTest { | |||
| /* | |||
| @BeforeClass | |||
| public static void init() { | |||
| PropertyConfigurator.configure("alluxio/conf/log4j.properties"); | |||
| PropertyConfigurator.configure("/Users/lucyge/Documents/github/alluxio/conf/log4j.properties"); | |||
There was a problem hiding this comment.
notice that the absolute path contains your own information
There was a problem hiding this comment.
ah good catch thanks!
|
alluxio-bot, merge this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Why are the changes needed?
To resolve:
Does this PR introduce any user facing changes?
No