Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http getPage cache hit ratio #18594

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

LuQQiu
Copy link
Contributor

@LuQQiu LuQQiu commented Apr 30, 2024

What changes are proposed in this pull request?

Add HTTP getPage cache hit ratio. This is used for mimicing how much data read from alluxio cache and how much data possibly fallback to UFS given that no that much user get metrics from alluxiofs client.

Why are the changes needed?

To get cache hit ratio of worker http server get page

Does this PR introduce any user facing changes?

Yes, add some metrics

@LuQQiu LuQQiu requested review from JiamingMai and ChunxuTang April 30, 2024 20:30
Copy link
Contributor

@ssz1997 ssz1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssz1997
Copy link
Contributor

ssz1997 commented Apr 30, 2024

alluxio-bot, merge this please

@alluxio-bot
Copy link
Contributor

merge failed:
Merge refused because pull request does not have label start with type-

@ssz1997 ssz1997 added the type-ease-of-use This issue is about of how to improve the ease of use of Alluxio product label Apr 30, 2024
@ssz1997
Copy link
Contributor

ssz1997 commented Apr 30, 2024

alluxio-bot, merge this please

@LuQQiu LuQQiu added type-feature This issue is a feature request and removed type-ease-of-use This issue is about of how to improve the ease of use of Alluxio product labels Apr 30, 2024
@LuQQiu
Copy link
Contributor Author

LuQQiu commented Apr 30, 2024

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 541f247 into Alluxio:main Apr 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature This issue is a feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants