Add back shaded netty within grpc #18642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xenorith
approved these changes
Jul 1, 2024
|
can you link the ancient old PR where this was originally added in case we have to trace back? |
jja725
added
type-debt
|
alluxio-bot, merge this please |
|
alluxio-bot, cherry-pick this to master-2.x please |
|
Auto cherry-pick unsuccessful Failed to setup local git for auto cherry-pick 05d2537 cannot be auto cherry-picked to branch master-2.x. Please cherry-pick this manually. |
|
cc @apc999 not sure if there is some historical context we're missing but letting grpc-netty use whichever netty we define, which may or may not be compatible, seems strictly worse than letting it use its own compatible version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
add back netty dependency within grpc
Why are the changes needed?
previously we exclude netty dependency since we already have netty-all outside #9942
But due to grpc/grpc-java#11284, we sometimes have incompatibility between grpc and netty, and it's better to use shaded netty within grpc so we can be sure that they are compatible.
Does this PR introduce any user facing changes?
na