-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support TMX relative path for Source texture #1303
Conversation
Hi, could you add a test for this. Can we copy an existing texture into another test directory, so that the tmx references a relative path, that should make it fail (i.e. return a dummy texture)? |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## dev #1303 +/- ##
============================================
- Coverage 59.60% 59.57% -0.04%
+ Complexity 2962 2956 -6
============================================
Files 308 308
Lines 15199 15199
Branches 1558 1558
============================================
- Hits 9060 9055 -5
- Misses 5610 5620 +10
+ Partials 529 524 -5
... and 4 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Hi, I've added an extra test that validates the checksum strategy. Hopefully, this suites the testing needs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, many thanks.
var sum = 0 | ||
for (x in 0 until image.getWidth().toInt()) { | ||
for (y in 0 until image.getHeight().toInt()) { | ||
sum += image.getPixelReader().getArgb(x, y) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how big argb values are, so perhaps Long is more suitable. Though I suppose identical values will overflow in the same way, so Int should work too.
Hi,
Issue Link: #1302
This change ensures that we can use the path specified on the tmx map file instead of removing the source file path at resource load time.