Framework uplift #40
Merged
Framework uplift #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble with net core Uplifted the net framework version to 4.7.2
|
@Adipa-G Awesome work! Thank you for giving this project some love. It's been a while. |
|
@Adipa-G Build failed... |
|
Hi,
Looks like we may need to use a later version of MSBuild in order to build
the solution.
I tried the build with MSBuild in my local machine (VS2019 community
edition). This ships with the MSBuild version 16.0.
[image: image.png]
Unfortunately since the project has WPF components it appears that we are
not able to use *dotnet build* command.
JetBrains/teamcity-dotnet-plugin#105
https://github.com/dotnet/cli/issues/6732
Let me know what you think.
Many thanks,
Adipa
…On Wed, 5 Jun 2019, 7:52 PM AlonAm ***@***.***> wrote:
@Adipa-G <https://github.com/Adipa-G> Build failed...
https://ci.appveyor.com/project/AlonAmsalem/nload
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40?email_source=notifications&email_token=AC3S653J36NE3772KXRGFWDPY6EERA5CNFSM4HS35LS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW7GOVA#issuecomment-499017556>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC3S6542D5U5GXB2PXFQMLTPY6EERANCNFSM4HS35LSQ>
.
|
|
Tried to change VS version on AppVeyor,, no change It's ok to disable WPF projects in Release mode for now |
|
Hi,
Looks like the build wasn't kicked off. The log file is empty.
Many Thanks,
Adipa
…On Thu, 6 Jun 2019, 1:23 AM AlonAm ***@***.***> wrote:
Tried to change VS version on AppVeyor,, no change
https://ci.appveyor.com/project/AlonAmsalem/nload-ucpcx
It's ok to disable WPF projects in Release mode for now
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40?email_source=notifications&email_token=AC3S65ZL5HREDHERCLH7GITPY7LABA5CNFSM4HS35LS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXACEUI#issuecomment-499130961>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC3S65YUXACIYJVQ44BG523PY7LABANCNFSM4HS35LSQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted the library to netstandard2 to make it compatible with dotnet core
Uplifted the net framework version to 4.7.2