Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should OpenDbRequest::set_on_upgrade_needed take a callback that returns a future? #30

Closed
zecakeh opened this issue Oct 31, 2023 · 1 comment
Closed

Should OpenDbRequest::set_on_upgrade_needed take a callback that returns a future? #30

zecakeh opened this issue Oct 31, 2023 · 1 comment
Assignees
@Alorel
Labels
Released This issue's resolution is now available in a published release

Comments

@zecakeh
Copy link

zecakeh commented Oct 31, 2023

In the callback we might need to await a transaction to make sure everything happens in the correct order.

For example porting the example of the "Structuring the database" section of MDN's guide is currently not possible.

They recommend to wait for the createObjectStore transaction to be completed before adding data in it. In Rust code that requires turning the transaction into a future.
@zecakeh zecakeh changed the title Should OpenDbRequest take a callback that returns a future? Should OpenDbRequest::on_upgrade_needed take a callback that returns a future? Oct 31, 2023
@zecakeh zecakeh changed the title Should OpenDbRequest::on_upgrade_needed take a callback that returns a future? Should OpenDbRequest::set_on_upgrade_needed take a callback that returns a future? Oct 31, 2023
@Alorel Alorel self-assigned this Oct 27, 2024
Alorel added a commit that referenced this issue Oct 27, 2024
@Alorel
feat: Accept async upgradeneeded closures
1426ac3 
Closes #30
Alorel added a commit that referenced this issue Oct 27, 2024
@Alorel
feat: Accept async upgradeneeded closures
ab7bc40 
Closes #30
Alorel added a commit that referenced this issue Oct 27, 2024
@Alorel
feat: Accept async upgradeneeded closures
0afd6e9 
Closes #30
Alorel added a commit that referenced this issue Oct 27, 2024
@Alorel
feat: Accept async upgradeneeded closures
baab359 
Closes #30
Alorel added a commit that referenced this issue Oct 27, 2024
@Alorel
feat: Accept async upgradeneeded closures
15631db 
Closes #30
Alorel added a commit that referenced this issue Oct 27, 2024
@Alorel
feat: Accept async upgradeneeded closures
3ba6647 
Closes #30
Alorel added a commit that referenced this issue Oct 27, 2024
@Alorel
feat: Accept async upgradeneeded closures
220e6a8 
Closes #30
Alorel added a commit that referenced this issue Oct 27, 2024
@Alorel
feat: Accept async upgradeneeded closures
36e4170 
Closes #30
Alorel added a commit that referenced this issue Oct 27, 2024
@Alorel
feat: Accept async upgradeneeded closures
4ad7f6b 
Closes #30
Alorel added a commit that referenced this issue Oct 27, 2024
@Alorel
feat: Accept async upgradeneeded closures
6dd4d5a 
Closes #30
@Alorel Alorel closed this as completed in a522c42 Oct 27, 2024
@Alorel
Copy link
Owner

Alorel commented Oct 27, 2024

This issue has been included in v0.6.0 🎉

- Your friendly neighbourhood 🤖 semantic release bot

@Alorel Alorel added the Released This issue's resolution is now available in a published release label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alorel Alorel

Labels
Released This issue's resolution is now available in a published release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alorel @zecakeh