Adding notification channel to support devices with Android 8.0 and above #943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a notification channel to be used in notifications posted by BluetoothMedic.
Posting notifications without a channel does not work on Android 8.0 and above
Expected Behavior:
When BluetoothMedic is used for power cycling bluetooth, on scan failures, and Medic notifications are enabled, when a scan failure occurs , bluetooth is power cycled and a notification is posted that says so.
Actual Behavior:
Bluetooth is power cycled, but no notification is posted.
If Settings> developer options > Show Notification channel warnings is turned on, a warning toast message can be seen, .
Steps to reproduce:
Use the android beacon library reference app and enable BluetoothMedic power cycling and notifications in RangingActivity
BluetoothMedic.getInstance().enablePowerCycleOnFailures(this);
BluetoothMedic.getInstance().setNotificationsEnabled( true, R.drawable.ic_launcher);
Broadcast an 'onScanFailed' to simulate an LE scan failure
Intent intent = new Intent("onScanFailed");
intent.putExtra("errorCode",2);
LocalBroadcastManager.getInstance(RangingActivity.this).sendBroadcast(intent);
Run RangingActivity
We should be able to see a bluetooth power cycling but no notification from BluetoothMedic
Device used : Galaxy Note 8
Android version : 9.0
Attaching screenshots for
before fix
after fix