-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lineage refactor #1212
Merged
Merged
feat: lineage refactor #1212
Changes from 2 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
4bd8d9c
feat: lineage v2
saravmajestic b0d6aaa
fix: lineage interactions
saravmajestic fb048de
chore: help button
saravmajestic 1da70b0
fix: action widget buttons
saravmajestic 0bc6223
revert: unnecessary changes
saravmajestic b6ba6f1
chore: updated components
saravmajestic bee9382
fix: styles
saravmajestic d1fcb2d
Merge branch 'master' into feat/lineage-v2
saravmajestic 9382b8f
fix: views code
saravmajestic da68973
Merge branch 'master' into feat/lineage-v2
saravmajestic e0c3649
fix: updated components
saravmajestic b4bbbc0
chore: cleanup
saravmajestic 9fe65ea
chore: cleanup
saravmajestic 13dcce1
Merge branch 'master' into feat/lineage-v2
saravmajestic fbec974
fix: static lineage integration
saravmajestic b3d8b2f
Merge branch 'master' into feat/lineage-v2
saravmajestic d7e3061
fix: merge issues
saravmajestic c8c38ad
fix: sql visualizer ui issues
saravmajestic 2f82023
Merge branch 'feat/lineage-v2' of https://github.com/AltimateAI/vscod…
saravmajestic d82bd80
fix: update lib version
saravmajestic 17e599b
fix: image cleanup
saravmajestic 5143e9a
revert: lib changes
saravmajestic 2df32ef
Merge branch 'master' into feat/lineage-v2
saravmajestic 1aa310c
fix: lineage components (#1311)
AdiGajbhiye f9910a4
fix: update components
saravmajestic 96be3e5
fix: minor issues
saravmajestic 1ef1ba4
fix: expand popover ui
saravmajestic 3eff7ba
fix: lineae demo
saravmajestic b5fde33
fix: lineage sidebar updates
saravmajestic 6f6c6b6
fix: feedback btn for sql lineage
saravmajestic e2d7702
fix: code block type error
AdiGajbhiye c3a4989
fix: sql lineage render
AdiGajbhiye 72c638b
fix: open url
AdiGajbhiye 02e407e
feat: added final builds
AdiGajbhiye edf489a
feat: added final builds
AdiGajbhiye 6284060
Merge branch 'master' into feat/lineage-v2
anandgupta42 c5fb15e
Merge branch 'master' into feat/lineage-v2
saravmajestic 7f268e2
fix: default expansion
AdiGajbhiye 8aa3e75
fix: reset
AdiGajbhiye dff48f1
Merge branch 'master' into feat/lineage-v2
AdiGajbhiye 16232b1
Merge branch 'master' into feat/lineage-v2
saravmajestic f685076
Merge branch 'master' into feat/lineage-v2
saravmajestic 67fd4f8
fix: ts error and update lib
saravmajestic ce8762d
fix: OOM
saravmajestic d27a9b8
Merge branch 'master' into feat/lineage-v2
AdiGajbhiye 747de74
merge commit
AdiGajbhiye f2cdd96
fix: eslint warning
saravmajestic a28d423
fix: new lineage
AdiGajbhiye bbd65e4
feat: lineage migrated to v2
AdiGajbhiye 3bcb5ae
fix: notification
AdiGajbhiye b2b4e73
feat: added build
AdiGajbhiye f182728
feat: saas init copied
AdiGajbhiye 8519f62
fix: lineage render
saravmajestic ebdafe9
Merge branch 'master' into feat/lineage-v2
anandgupta42 c1c03fe
feat: updated build files
AdiGajbhiye File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Review the LineageDemo component implementation.
The
LineageDemo
component is well-structured and consistent with other components in the file. However, there are a couple of points that need attention:@ts-expect-error
) might hide underlying type issues. Consider addressing the root cause instead of suppressing the error.window.lineageGif
assumes it's defined somewhere else, which could lead to runtime errors if not properly managed. Ensure that this global variable is consistently set where needed.To address these issues, consider refactoring the component as follows:
This approach type-checks the
window
object and uses a type assertion only when necessary, reducing the risk of runtime errors.Note: While a similar comment was made in a previous review, this new comment is necessary as the issues haven't been fully addressed in the current implementation.