AltimateAI · anandgupta42 · Oct 28, 2024 · Jun 13, 2024 · Jun 13, 2024 · Jun 13, 2024
diff --git a/new_lineage_panel/src/service_utils.ts b/new_lineage_panel/src/service_utils.ts
@@ -38,7 +38,7 @@ export const openFile = (url: string) => {
 };
 
 export const openURL = (url: string) => {
-  vscode.postMessage({ command: "openURL", args: { url } });
+  vscode.postMessage({ command: "openURL", url });
 };
 
 export const openChat = () => openURL("https://app.myaltimate.com/contactus");

diff --git a/src/altimate.ts b/src/altimate.ts
@@ -79,7 +79,7 @@ interface SQLLineageRequest {
   session_id: string;
 }
 
-export type Details = Record<
+export type SqlLineageDetails = Record<
   string,
   {
     name: string;
@@ -90,9 +90,9 @@ export type Details = Record<
     columns: { name: string; datatype?: string; expression?: string }[];
   }
 >;
-type StaticLineageResponse = {
+type SqlLineageResponse = {
   tableEdges: [string, string][];
-  details: Details;
+  details: SqlLineageDetails;
   nodePositions?: Record<string, [number, number]>;
 };
 
@@ -933,7 +933,7 @@ export class AltimateRequest {
   }
 
   async sqlLineage(req: SQLLineageRequest) {
-    return this.fetch<StaticLineageResponse>("dbt/v3/sql_lineage", {
+    return this.fetch<SqlLineageResponse>("dbt/v3/sql_lineage", {
       method: "POST",
       body: JSON.stringify(req),
     });

diff --git a/src/commands/index.ts b/src/commands/index.ts
@@ -700,7 +700,7 @@ export class VSCodeCommands implements Disposable {
                 ViewColumn.Two,
                 { retainContextWhenHidden: true, enableScripts: true },
               );
-              this.sqlLineagePanel.resolveWebviewView(panel, lineage);
+              this.sqlLineagePanel.renderSqlVisualizer(panel, lineage);
             } catch (e) {
               const errorMessage = (e as Error)?.message;
               this.dbtTerminal.error("sqlLineage", errorMessage, e, true);

diff --git a/src/webview_provider/altimateWebviewProvider.ts b/src/webview_provider/altimateWebviewProvider.ts
@@ -524,6 +524,17 @@ export class AltimateWebviewProvider implements WebviewViewProvider {
     }
   }
 
+  protected async checkIfWebviewReady() {
+    return new Promise<void>((resolve) => {
+      const interval = setInterval(() => {
+        if (this.isWebviewReady) {
+          clearInterval(interval);
+          resolve();
+        }
+      }, 500);
+    });
+  }
+
   resolveWebviewView(
     panel: WebviewView,
     context: WebviewViewResolveContext<unknown>,
@@ -587,6 +598,17 @@ export class AltimateWebviewProvider implements WebviewViewProvider {
         ),
       ),
     );
+    const LineageGif = webview.asWebviewUri(
+      Uri.file(
+        path.join(
+          extensionUri.fsPath,
+          "webview_panels",
+          "dist",
+          "assets",
+          "lineage.gif",
+        ),
+      ),
+    );
     const codiconsUri = webview.asWebviewUri(
       Uri.joinPath(
         extensionUri,
@@ -616,12 +638,14 @@ export class AltimateWebviewProvider implements WebviewViewProvider {
             <link rel="stylesheet" type="text/css" href="${codiconsUri}">
           </head>
 
-          <body>
+          <body class="${this.viewPath.replace(/\//g, "")}">
             <div id="root"></div>
             <div id="sidebar"></div>
+            <div id="modal"></div>
             <script nonce="${nonce}" >
               window.viewPath = "${this.viewPath}";
               var spinnerUrl = "${SpinnerUrl}"
+              var lineageGif = "${LineageGif}"
             </script>
 
             <script nonce="${nonce}" type="module" src="${indexJs}"></script>

diff --git a/src/webview_provider/lineagePanel.ts b/src/webview_provider/lineagePanel.ts
@@ -139,7 +139,7 @@ export class LineagePanel implements WebviewViewProvider, Disposable {
     const { command, args } = message;
     // common commands
     if (command === "openFile") {
-      const { url } = args;
+      const url = args.params?.url;
       if (!url) {
         return;
       }
@@ -173,14 +173,6 @@ export class LineagePanel implements WebviewViewProvider, Disposable {
       return;
     }
 
-    if (command === "openURL") {
-      if (!args.url) {
-        return;
-      }
-      env.openExternal(Uri.parse(args.url));
-      return;
-    }
-
     if (command === "reactError") {
       const typeMapper: { [key: string]: string } = {
         generic: "Generic",