[wip] debug wrong disks table parts creation and empty files upload, …

…locally reproduced #676
Altinity · Jun 26, 2023 · e9bca26 · e9bca26
1 parent ab4011a
commit e9bca26
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/pkg/backup/create.go b/pkg/backup/create.go
@@ -458,7 +458,7 @@ func (b *Backuper) AddTableToBackup(ctx context.Context, backupName, shadowBacku
 		return nil, nil, fmt.Errorf("backupName is not defined")
 	}
 
-	if !strings.HasSuffix(table.Engine, "MergeTree") && table.Engine != "MaterializedMySQL" && table.Engine != "MaterializedPostgreSQL" {
+	if !strings.HasSuffix(table.Engine, "MergeTree") && table.Engine != "MaterializedMySQL" && table.Engine != "MaterializedPostgreSQL" && table.Engine != "MaterializedView" {
 		log.WithField("engine", table.Engine).Warnf("supports only schema backup")
 		return nil, nil, nil
 	}

diff --git a/test/integration/config-s3.yml b/test/integration/config-s3.yml
@@ -10,6 +10,9 @@ general:
     - "_temporary_and_external_tables.*"
   restore_schema_on_cluster: "{cluster}"
 clickhouse:
+  # wrong disk name mapping for https://github.com/Altinity/clickhouse-backup/issues/676
+  disk_mapping:
+    default-gp3: /var/lib/clickhouse
   host: 127.0.0.1
   port: 9440
   username: backup

diff --git a/test/integration/docker-compose_advanced.yml b/test/integration/docker-compose_advanced.yml
@@ -45,6 +45,8 @@ services:
       MINIO_ROOT_PASSWORD: it-is-my-super-secret-key
     volumes:
       - ./minio_nodelete.sh:/bin/minio_nodelete.sh
+    ports:
+      - "9001:9001"
     networks:
       - clickhouse-backup