-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: update clickhouse-go to v2 #562
Conversation
local build is ok, unit tests are also OK. will try launch integration tests today and share the results |
Integration tests failed Could you change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we return error in chbackend.Query
after switch to v2?
yep, i've missed this file, working on it
https://github.com/anikin-aa/clickhouse-backup/blob/clickhouse-go/v2/pkg/clickhouse/clickhouse.go#L724-L726 error already returned, need to do changes in |
@anikin-aa any progress? |
@Slach , hi !
there is one ugly part here: https://github.com/anikin-aa/clickhouse-backup/blob/clickhouse-go/v2/test/integration/integration_test.go#L1713-L1726 my be you could suggest better approach ? |
;(( Don't sure we should to approve this PR in this case Maybe we should switch from native to http protocol? |
Not so much to be honest, just take the latest available library
http right now set as experimental for clickhouse-go https://github.com/ClickHouse/clickhouse-go#https-experimental I will try to check what's possible to do with old ch versions |
@anikin-aa |
lets wait and resolve conflicts |
lookg progress #669 |
Update clickhouse-go module to v2. Fix integration tests according to new contract from the lib