create new modeler instance always, but only call getModeler once in … #13235
standerenfrontend-unit-tests.yml
on: push
CodeQL
3m 42s
Typechecking and linting
3m 41s
Testing
9m 51s
Building
2m 16s
Annotations
2 errors and 1 warning
|
useBpmnModeler › should avoid creating a new instance of the class if it already has an instance:
frontend/packages/process-editor/src/hooks/useBpmnModeler/useBpmnModeler.test.ts#L39
expect(received).not.toBe(expected) // Object.is equality
Expected: not "<div>MockedHtml2</div>"
at Object.toBe (packages/process-editor/src/hooks/useBpmnModeler/useBpmnModeler.test.ts:39:54)
|
|
Testing
Process completed with exit code 1.
|
|
Typechecking and linting:
frontend/packages/process-editor/src/hooks/useBpmnEditor.ts#L99
React Hook useEffect has missing dependencies: 'getModeler', 'initializeBpmnChanges', 'initializeEditor', and 'modelerRef'. Either include them or remove the dependency array
|