Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format all existing files using Prettier #11241

Closed
mlqn opened this issue Sep 26, 2023 · 0 comments · Fixed by #12141 or #12154
Closed

Format all existing files using Prettier #11241

mlqn opened this issue Sep 26, 2023 · 0 comments · Fixed by #12141 or #12154
Labels
kind/chore quality/code Violations from current rules for code, best practices, etc. Or just bad code. quality/debt Shortcuts made for saving time. Fixing this will make us more efficient going forward. status/triage

Comments

@mlqn
Copy link
Contributor

mlqn commented Sep 26, 2023

Description

We currently have approximately 350 files that are not formatted according to our Prettier rules. This makes PRs harder to review when some of these files are edited.

I suggest fixing them once and for all by using the yarn prettier . -w command.

It could be a good idea to prevent linking this commit to someone in particular as suggested here.
Not sure what is the best solution, but one easy way to do it could be to create an artificial committer:

git config user.name "Prettier"
git config user.email "prettier@..."

We also need to find the right time to do it, preferably when we have fewer active feature branches, to reduce the risk of creating multiple merge conflicts.

Additional Information

No response

Tasks

No response

Acceptance Criterias

No response

@mlqn mlqn added status/draft Status: When you create an issue before you have enough info to properly describe the issue. kind/chore labels Sep 26, 2023
@mlqn mlqn added status/triage and removed status/draft Status: When you create an issue before you have enough info to properly describe the issue. labels Nov 22, 2023
@mlqn mlqn added quality/code Violations from current rules for code, best practices, etc. Or just bad code. quality/debt Shortcuts made for saving time. Fixing this will make us more efficient going forward. labels Dec 18, 2023
@TomasEng TomasEng linked a pull request Jan 25, 2024 that will close this issue
2 tasks
@github-project-automation github-project-automation bot moved this to 🧪 Test in Team Studio Jan 25, 2024
@TomasEng TomasEng linked a pull request Jan 25, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore quality/code Violations from current rules for code, best practices, etc. Or just bad code. quality/debt Shortcuts made for saving time. Fixing this will make us more efficient going forward. status/triage
Projects
Archived in project
1 participant