Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Prettier on the frontend #12141

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Run Prettier on the frontend #12141

merged 1 commit into from
Jan 25, 2024

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Jan 24, 2024 •
edited
Loading

Description

  • Ran Prettier on the entire frontend folder to avoid codestyle related merge conflicts.
  • Added codestyle:check and codestyle:fix to package.json
  • Added codestyle check to the Typechecking and linting workflow

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. area/dashboard Area: Related to the dashboard application area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. area/text-editor area/studio-root Area: Issues related to studio-root application labels Jan 24, 2024
@TomasEng TomasEng force-pushed the frontend-prettier branch 3 times, most recently from 69f8f7a to e98900d Compare January 24, 2024 14:24
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2024 •
edited
Loading

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (51b1416) 87.96% compared to head (ac09198) 87.96%.

Files Patch % Lines
.../hooks/mutations/useUpdateFormComponentMutation.ts 56.25% 5 Missing and 2 partials ⚠️
...hooks/useSearchParamsState/useSearchParamsState.ts 53.84% 6 Missing ⚠️
...ges/schema-editor/test/renderHookWithProviders.tsx 61.53% 5 Missing ⚠️
...c/components/toolbar/ConditionalRenderingModal.tsx 40.00% 3 Missing ⚠️
...ackages/schema-editor/test/renderWithProviders.tsx 84.61% 1 Missing and 1 partial ⚠️
...shared/src/components/molecules/AltinnMenuItem.tsx 0.00% 2 Missing ⚠️
.../hooks/mutations/useUpsertTextResourcesMutation.ts 60.00% 1 Missing and 1 partial ⚠️
...ckages/shared/src/hooks/useReactiveLocalStorage.ts 66.66% 2 Missing ⚠️
...c/hooks/mutations/useFormLayoutSettingsMutation.ts 33.33% 1 Missing and 1 partial ⚠️
frontend/app-development/utils/urlHelper.ts 75.00% 1 Missing ⚠️
... and 10 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12141      +/-   ##
==========================================
- Coverage   87.96%   87.96%   -0.01%     
==========================================
  Files         978      978              
  Lines       14046    14065      +19     
  Branches     1707     1712       +5     
==========================================
+ Hits        12356    12372      +16     
- Misses       1477     1481       +4     
+ Partials      213      212       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the skip-releasenotes Issues that do not make sense to list in our release notes label Jan 25, 2024
@TomasEng TomasEng linked an issue Jan 25, 2024 that may be closed by this pull request
Format all existing files using Prettier #11241
Closed
@TomasEng TomasEng added quality/code Violations from current rules for code, best practices, etc. Or just bad code. quality/debt Shortcuts made for saving time. Fixing this will make us more efficient going forward. labels Jan 25, 2024
@TomasEng TomasEng marked this pull request as ready for review January 25, 2024 07:59
framitdavid
framitdavid approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@TomasEng TomasEng merged commit a41e3b9 into main Jan 25, 2024
10 of 12 checks passed
@TomasEng TomasEng deleted the frontend-prettier branch January 25, 2024 08:06
@ErlingHauan ErlingHauan mentioned this pull request Feb 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@framitdavid framitdavid framitdavid approved these changes

Assignees
No one assigned
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. area/dashboard Area: Related to the dashboard application area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/studio-root Area: Issues related to studio-root application area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. quality/code Violations from current rules for code, best practices, etc. Or just bad code. quality/debt Shortcuts made for saving time. Fixing this will make us more efficient going forward. quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format all existing files using Prettier
2 participants
@TomasEng @framitdavid