Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type for expressions #11373

Closed
TomasEng opened this issue Oct 17, 2023 · 2 comments
Closed

Add type for expressions #11373

TomasEng opened this issue Oct 17, 2023 · 2 comments
Labels
quality/code Violations from current rules for code, best practices, etc. Or just bad code. team/studio

Comments

@TomasEng
Copy link
Contributor

TomasEng commented Oct 17, 2023 •
edited by standeren
Loading

Description

Dynamic expressions in Studio currently use the any type in Typescript because they are rather complicated. This makes them hard to work with in the code, so we should create a type that is as precise as possible.

However, currently we do not have a good way to validate the expressions (at least those written free style which are evaluated as complex expression), so we first need to find a way to integrate the apps validation of expressions. Preferably as a shared package, but maybe by apps exposing it.

See discussion in this PR for information on the topic
@TomasEng TomasEng converted this from a draft issue Oct 17, 2023
@TomasEng TomasEng added quality/code Violations from current rules for code, best practices, etc. Or just bad code. team/studio labels Oct 17, 2023
@standeren standeren moved this from 📈 Todo to ⚠️ Blocked in Team Studio Oct 27, 2023
@standeren standeren self-assigned this Oct 27, 2023
@standeren standeren moved this from ⚠️ Blocked to 👷 In Progress in Team Studio Oct 27, 2023
@standeren standeren linked a pull request Nov 3, 2023 that will close this issue
11373 add type for expressions #11486
Merged
3 tasks
@standeren standeren moved this from 👷 In Progress to 🔎 Review in Team Studio Nov 3, 2023
@TomasEng TomasEng mentioned this issue Nov 7, 2023
Merged
3 tasks
@standeren standeren removed a link to a pull request Nov 8, 2023
11373 add type for expressions #11486
Merged
3 tasks
@standeren standeren removed their assignment Nov 8, 2023
@TomasEng TomasEng self-assigned this Nov 8, 2023
@TomasEng TomasEng moved this from 🔎 Review to ⚠️ Blocked in Team Studio Nov 9, 2023
@TomasEng
Copy link
Contributor Author

TomasEng commented Nov 9, 2023

Blocked because ve are awaiting validation. Currently we have a raw text input without validation on the expressions, so they can truly be anything.

@TomasEng TomasEng removed their assignment Nov 9, 2023
@TomasEng
Copy link
Contributor Author

Will be resolved by #12183.

@github-project-automation github-project-automation bot moved this from ⚠️ Blocked to 🧪 Test in Team Studio Feb 28, 2024
@TomasEng TomasEng removed the status in Team Studio Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
quality/code Violations from current rules for code, best practices, etc. Or just bad code. team/studio
Projects
Team Studio
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TomasEng @standeren