Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-factor expressions editor to be more generic and re-usable #12183

Closed
Tracked by #12094 ...
nkylstad opened this issue Jan 28, 2024 · 4 comments · Fixed by #12406
Closed
Tracked by #12094 ...

Re-factor expressions editor to be more generic and re-usable #12183

nkylstad opened this issue Jan 28, 2024 · 4 comments · Fixed by #12406

Comments

@nkylstad
Copy link
Member

nkylstad commented Jan 28, 2024

Description

Expressions are used in several places in an app, f.ex:

  • several different component properties
  • layout (hidden property)
  • texts
  • process sequence flows (from gateways)

The expressions editor is currently only implemented for the components use case, and is likely a little too tied to that case.
We should extract the essentials into a new, re-usable component that takes context as input in order to be able to generate expressions in all of the above cases.

@nkylstad nkylstad moved this to 📈 Todo in Team Studio Jan 29, 2024
@TomasEng TomasEng self-assigned this Feb 12, 2024
@TomasEng TomasEng moved this from 📈 Todo to 👷 In Progress in Team Studio Feb 12, 2024
@TomasEng TomasEng linked a pull request Feb 27, 2024 that will close this issue
3 tasks
@TomasEng TomasEng mentioned this issue Feb 27, 2024
3 tasks
@TomasEng TomasEng moved this from 👷 In Progress to 🔎 Review in Team Studio Feb 28, 2024
@TomasEng TomasEng removed their assignment Feb 28, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Studio Mar 1, 2024
@TomasEng TomasEng reopened this Mar 1, 2024
@TomasEng TomasEng removed their assignment Mar 1, 2024
@standeren
Copy link
Contributor

Came across an issue from this PR when testing something else; when filtering the component properties for Repeating Group for finding the properties that may have expressions, edit prop is not always set when searching for the subkey.
Quickfix in this PR #12435

@TomasEng
Copy link
Contributor

TomasEng commented Mar 12, 2024

På grunn av en feil i designsystemet kan det dukke opp noen overskrifter som egentlig ikke skal være synlige på skjermen. Dette er fikset i versjon 0.51.3 av designsystemet.

@TomasEng
Copy link
Contributor

Takket være feilen nevnt over oppdaget jeg en annen feil, i en tekstreferanse. Den er fikset her: #12493

@lassopicasso lassopicasso self-assigned this Mar 20, 2024
@lassopicasso
Copy link
Contributor

Tested in dev - encountered two bugs while testing the functionality of expressions.
Created bug issues for these two:

@lassopicasso lassopicasso moved this from 🧪 Test to ✅ Done in Team Studio Mar 21, 2024
@lassopicasso lassopicasso removed their assignment Mar 21, 2024
@nkylstad nkylstad closed this as completed Apr 3, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🧪 Test in Team Studio Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants