Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group type refactor #11524

Closed
TomasEng opened this issue Nov 7, 2023 · 1 comment
Closed

Group type refactor #11524

TomasEng opened this issue Nov 7, 2023 · 1 comment
Labels
kind/analysis Used when an issue needs to be analysed before it becomes a user story. quality/code Violations from current rules for code, best practices, etc. Or just bad code. status/for-consideration Issues that need consideration by team

Comments

@TomasEng
Copy link
Contributor

TomasEng commented Nov 7, 2023

The ExpressionPropertyForGroup enum has values prefixed with edit.. This prefix is then hardcoded in the code to match the enum value, so this is not ideal. Also, this should be synchronized with the edit property of the FormContainer type, which is currently just KeyValuePairs.

export enum ExpressionPropertyForGroup {
  EditAddButton = 'edit.addButton',
  EditDeleteButton = 'edit.deleteButton',
  EditSaveButton = 'edit.saveButton',
  EditSaveAndNextButton = 'edit.saveAndNextButton',
}
@TomasEng TomasEng converted this from a draft issue Nov 7, 2023
@TomasEng TomasEng added kind/bug Used when there is a defect / something is not working as it should. quality/code Violations from current rules for code, best practices, etc. Or just bad code. status/draft Status: When you create an issue before you have enough info to properly describe the issue. and removed kind/bug Used when there is a defect / something is not working as it should. labels Nov 7, 2023
@TomasEng TomasEng mentioned this issue Nov 7, 2023
Merged
4 tasks
@TomasEng TomasEng added kind/analysis Used when an issue needs to be analysed before it becomes a user story. and removed status/draft Status: When you create an issue before you have enough info to properly describe the issue. labels Nov 7, 2023
@nkylstad nkylstad added the status/for-consideration Issues that need consideration by team label Nov 15, 2023
@TomasEng
Copy link
Contributor Author

TomasEng commented Mar 4, 2024

This has been resolved by #12183.

@TomasEng TomasEng closed this as completed Mar 4, 2024
@github-project-automation github-project-automation bot moved this from 📈 Todo to 🧪 Test in Team Studio Mar 4, 2024
@TomasEng TomasEng moved this from 🧪 Test to ✅ Done in Team Studio Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/analysis Used when an issue needs to be analysed before it becomes a user story. quality/code Violations from current rules for code, best practices, etc. Or just bad code. status/for-consideration Issues that need consideration by team
Projects
Team Studio
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nkylstad @TomasEng