Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for formItem[key] before fetching formItem[key][subKey] #12435

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Mar 4, 2024

Description

fix cannot read properties of undefined reading 'addButton' on edit prop on RepeatingGroup when filtering properties on component that have expressions set

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Mar 4, 2024
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bra sett, @standeren, og bra at du la til en test for det!

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.45%. Comparing base (390f7e6) to head (ca38c4f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12435   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files        1270     1270           
  Lines       18450    18450           
  Branches     2288     2288           
=======================================
  Hits        16136    16136           
  Misses       2040     2040           
  Partials      274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren merged commit 5c22d34 into main Mar 4, 2024
11 checks passed
@standeren standeren deleted the bug/rep-group-expressions-filtering branch March 4, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants