Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong text key in expressions #12493

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Mar 13, 2024

Description

The reference to the subexpression text had wrong casing, so the text was not found.

Related issue

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base (a43f44c) to head (fc1b182).
Report is 1 commits behind head on main.

❗ Current head fc1b182 differs from pull request most recent head 22bd572. Consider uploading reports for the commit 22bd572 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12493   +/-   ##
=======================================
  Coverage   88.10%   88.10%           
=======================================
  Files        1271     1271           
  Lines       18321    18321           
  Branches     2263     2263           
=======================================
  Hits        16142    16142           
  Misses       1909     1909           
  Partials      270      270           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomasEng TomasEng marked this pull request as ready for review March 13, 2024 07:10
@TomasEng TomasEng added the kind/bug Used when there is a defect / something is not working as it should. label Mar 13, 2024
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@TomasEng TomasEng merged commit 756d046 into main Mar 13, 2024
3 checks passed
@TomasEng TomasEng deleted the fix-wrong-text-key-in-expressions branch March 13, 2024 08:51
nkylstad pushed a commit that referenced this pull request Mar 13, 2024
nkylstad pushed a commit that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Used when there is a defect / something is not working as it should. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants