Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong validation message when editing component id #12007

Closed
2 tasks
mlqn opened this issue Jan 11, 2024 · 5 comments · Fixed by #12649
Closed
2 tasks

Wrong validation message when editing component id #12007

mlqn opened this issue Jan 11, 2024 · 5 comments · Fixed by #12649
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. kind/bug Used when there is a defect / something is not working as it should. status/ready-for-specification Status: Used for issues that are ready for functional decription og detailed design.

Comments

@mlqn
Copy link
Contributor

mlqn commented Jan 11, 2024

Description of the bug

It is not possible to write a component id shorter than 2 characters, to only use numbers, to start with -, etc, which is not specified in the error message:
Komponent-ID kan kun bestå av engelske bokstaver, tall og '-' tegnet.

Why is the validation regex so restrictive?

Steps To Reproduce

Screen.Recording.2024-01-11.at.12.56.28.mov

Additional Information

No response

Tasks

Preview Give feedback
@mlqn mlqn added kind/bug Used when there is a defect / something is not working as it should. status/triage labels Jan 11, 2024
@mlqn mlqn added the area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. label Jan 11, 2024
@nkylstad nkylstad added status/ready-for-specification Status: Used for issues that are ready for functional decription og detailed design. and removed status/triage labels Mar 15, 2024
@framitdavid framitdavid moved this to 📈 Todo in Team Studio Mar 22, 2024
@ghost ghost assigned ghost and unassigned ghost Apr 8, 2024
@ghost
Copy link

ghost commented Apr 9, 2024

After discussing with Team Apps, this is what should be required for the ID pattern:

  • Can not start with -
  • Can not end with - followed by a number
  • Only have english letters
  • Would be smart to have the length to minimum 2
    The message should be updated to reflect the pattern.

@Ildest @Annikenkbrathen do you have a suggestion to an error message that would be better?
This might be too long and complicated: Komponent-ID må ha minimum 2 tegn, kan ikke starte med -, kan ikke avslutte med - etterfulgt av tall, og kan kun bestå av engelske bokstaver, tall og bindestrek.

@Ildest
Copy link
Contributor

Ildest commented Apr 10, 2024 via email

@ghost ghost moved this from 📈 Todo to 👷 In Progress in Team Studio Apr 10, 2024
@Ildest
Copy link
Contributor

Ildest commented Apr 10, 2024

Forslag @WilliamThorenfeldt : Komponent-ID-en må ha minst 2 tegn. ID-en kan ikke starte med bindestrek (-) eller slutte med bindestrek og tall. Bruk bare tegn fra det engelske alfabetet.

@ghost
Copy link

ghost commented Apr 10, 2024

Supert @Ildest, takk for det 😄

@ghost ghost mentioned this issue Apr 10, 2024
3 tasks
@ghost ghost linked a pull request Apr 10, 2024 that will close this issue
3 tasks
@ghost ghost removed their assignment Apr 10, 2024
@ghost ghost moved this from 👷 In Progress to 🔎 Review in Team Studio Apr 10, 2024
@JamalAlabdullah JamalAlabdullah assigned JamalAlabdullah and ghost and unassigned JamalAlabdullah Apr 11, 2024
@ghost ghost closed this as completed in #12649 Apr 11, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Studio Apr 11, 2024
@JamalAlabdullah JamalAlabdullah assigned JamalAlabdullah and unassigned ghost Apr 11, 2024
@JamalAlabdullah
Copy link
Contributor

Tested i dev💯

@JamalAlabdullah JamalAlabdullah moved this from 🧪 Test to ✅ Done in Team Studio Apr 11, 2024
@JamalAlabdullah JamalAlabdullah removed their assignment Apr 11, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. kind/bug Used when there is a defect / something is not working as it should. status/ready-for-specification Status: Used for issues that are ready for functional decription og detailed design.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants