Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use app's frontend version in preview #12149

Closed
Tracked by #11822
nkylstad opened this issue Jan 25, 2024 · 1 comment · Fixed by #12202
Closed
Tracked by #11822

Use app's frontend version in preview #12149

nkylstad opened this issue Jan 25, 2024 · 1 comment · Fixed by #12202
Assignees
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. status/ready-for-dev Status: Used for issues that are ready for development. Has been through grooming.

Comments

@nkylstad
Copy link
Member

nkylstad commented Jan 25, 2024

Description

Our preview uses the same app-frontend version for all apps. We should update preview to use the specific version that a given app is set up with, so that f.ex:

  • v4 apps show v4 app frontend in preview
  • v3 apps show v3 app frontend in preview
  • an app that uses the explicit version f.ex. 3.56.3 should be shown this explicit version in preview

We have an endpoint that fetched both app-frontend and app-lib (backend) versjon for the app.

We should be able to fetch the .cshtml-file from the app-repo, instead of our studio-copy. In this way we don't need to fetch the version, just use the file directly.

@nkylstad nkylstad mentioned this issue Jan 25, 2024
@nkylstad nkylstad added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. status/ready-for-dev Status: Used for issues that are ready for development. Has been through grooming. area/ui-component labels Jan 28, 2024
@nkylstad nkylstad moved this to 📈 Todo in Team Studio Jan 29, 2024
@standeren standeren moved this from 📈 Todo to 👷 In Progress in Team Studio Jan 29, 2024
@standeren standeren self-assigned this Jan 29, 2024
@standeren standeren moved this from 👷 In Progress to 🔎 Review in Team Studio Jan 30, 2024
@standeren standeren removed their assignment Jan 30, 2024
@nkylstad nkylstad self-assigned this Jan 30, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Studio Jan 30, 2024
@nkylstad
Copy link
Member Author

nkylstad commented Feb 1, 2024

Tested with several different versions of app-frontend. In each case, I could see that the file that was loaded for app-frontend matched the response from the version-api. So this works as expected!

@nkylstad nkylstad moved this from 🧪 Test to ✅ Done in Team Studio Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. status/ready-for-dev Status: Used for issues that are ready for development. Has been through grooming.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants