Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch cshtml from app to render correct app-frontend version in preview #12202

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

standeren
Copy link
Contributor

Description

Add endpoint to fetch cshtml file from app-repo and add helper method to modify cshtml to take into account additional route path in the iframe

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@standeren standeren linked an issue Jan 30, 2024 that may be closed by this pull request
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Jan 30, 2024
@standeren standeren force-pushed the 12149-use-apps-frontend-version-in-preview branch from c7453ab to 711621f Compare January 30, 2024 12:42
@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea75b66) 87.81% compared to head (711621f) 87.82%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12202   +/-   ##
=======================================
  Coverage   87.81%   87.82%           
=======================================
  Files         971      971           
  Lines       13815    13815           
  Branches     1705     1705           
=======================================
+ Hits        12132    12133    +1     
+ Misses       1473     1472    -1     
  Partials      210      210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren marked this pull request as ready for review January 30, 2024 12:55
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🥳

@standeren standeren merged commit 40a8095 into main Jan 30, 2024
17 checks passed
@standeren standeren deleted the 12149-use-apps-frontend-version-in-preview branch January 30, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use app's frontend version in preview
2 participants