Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Children of a container must be deleted when container is deleted #12300

Closed
standeren opened this issue Feb 13, 2024 · 3 comments
Closed

Children of a container must be deleted when container is deleted #12300

standeren opened this issue Feb 13, 2024 · 3 comments
Assignees
@framitdavid
Labels
added-to-sprint kind/bug Used when there is a defect / something is not working as it should.

Comments

@standeren
Copy link
Contributor

standeren commented Feb 13, 2024 •
edited
Loading

Description

When deleting a container component with existing children the child components are not deleted from the layout.

Skjermopptak.2024-02-13.kl.16.15.28.mov
@standeren standeren converted this from a draft issue Feb 13, 2024
@standeren standeren added added-to-sprint kind/bug Used when there is a defect / something is not working as it should. labels Feb 13, 2024
@framitdavid framitdavid moved this from 📈 Todo to 👷 In Progress in Team Studio Feb 15, 2024
@framitdavid framitdavid self-assigned this Feb 15, 2024
@framitdavid framitdavid mentioned this issue Feb 21, 2024
Merged
3 tasks
@framitdavid framitdavid moved this from 👷 In Progress to 🔎 Review in Team Studio Feb 21, 2024
@framitdavid framitdavid removed their assignment Feb 21, 2024
@lassopicasso lassopicasso moved this from 🔎 Review to 🧪 Test in Team Studio Feb 21, 2024
@lassopicasso lassopicasso moved this from 🧪 Test to 🔎 Review in Team Studio Feb 21, 2024
@framitdavid framitdavid moved this from 🔎 Review to 🧪 Test in Team Studio Feb 21, 2024
@framitdavid framitdavid removed their assignment Feb 21, 2024
@standeren standeren self-assigned this Feb 21, 2024
@standeren
Copy link
Contributor Author

Works as expected 💯
But should we adapt the alert to include information that all child-components also will be deleted?

Image

@standeren standeren assigned framitdavid and unassigned standeren Feb 21, 2024
@standeren standeren moved this from 🧪 Test to 👀 Test feedback in Team Studio Feb 21, 2024
@framitdavid framitdavid mentioned this issue Feb 21, 2024
Merged
3 tasks
@framitdavid
Copy link
Collaborator

Excellent suggestion, @standeren! I've incorporated your suggestion into this pull request: Link to PR.

@framitdavid
Copy link
Collaborator

Tested OK in dev.

Image

@github-project-automation github-project-automation bot moved this from 👀 Test feedback to 🧪 Test in Team Studio Feb 22, 2024
@framitdavid framitdavid moved this from 🧪 Test to ✅ Done in Team Studio Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@framitdavid framitdavid

Labels
added-to-sprint kind/bug Used when there is a defect / something is not working as it should.
Projects
Team Studio
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@framitdavid @standeren @lassopicasso