Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UseDeleteFormContainerMutation): Ensure to delete all children of container components when the container is deleted. #12357

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Feb 21, 2024

Description

Ensure to delete all children of container components when the container component is deleted.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@framitdavid framitdavid marked this pull request as draft February 21, 2024 08:22
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Feb 21, 2024
@framitdavid framitdavid changed the title Fix/delete child components from container fix(UseDeleteFormContainerMutation): Ensure to delete all children of container components when the container component is deleted. Feb 21, 2024
@framitdavid framitdavid changed the title fix(UseDeleteFormContainerMutation): Ensure to delete all children of container components when the container component is deleted. fix(UseDeleteFormContainerMutation): Ensure to delete all children of container components when the container is deleted. Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (379b392) 86.56% compared to head (a5112e2) 86.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12357   +/-   ##
=======================================
  Coverage   86.56%   86.56%           
=======================================
  Files        1199     1199           
  Lines       18056    18058    +2     
  Branches     2286     2286           
=======================================
+ Hits        15630    15632    +2     
  Misses       2142     2142           
  Partials      284      284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@framitdavid framitdavid marked this pull request as ready for review February 21, 2024 08:32
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@framitdavid framitdavid merged commit 383ef8e into main Feb 21, 2024
10 checks passed
@framitdavid framitdavid deleted the fix/deleteChildComponentsFromContainer branch February 21, 2024 12:52
standeren pushed a commit that referenced this pull request Feb 21, 2024
… container components when the container is deleted. (#12357)

* fix(UseDeleteFormContainerMutation): ensure to delete child components from layouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants