Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StudioTableRemotePagination - maintain height when spinner is displayed #13040

Closed
ErlingHauan opened this issue Jun 27, 2024 · 3 comments · Fixed by #13137
Closed

StudioTableRemotePagination - maintain height when spinner is displayed #13040

ErlingHauan opened this issue Jun 27, 2024 · 3 comments · Fixed by #13137
Labels
kind/chore status/ready-for-dev Status: Used for issues that are ready for development. Has been through grooming.

Comments

@ErlingHauan
Copy link
Contributor

ErlingHauan commented Jun 27, 2024

Description

Table jumping when navigating between pages

When navigating between pages of the table, the height of the table container changes when the spinner appears/disappears. This only happens when the "page" in the table is not cached. Ideally only the content of the table should be hidden by the spinner, and the height should be unchanged so that the table doesn't "jump" up and down.

Screen.Recording.2024-06-27.at.10.28.10.mov

Add support for prefetching

Use Tanstack Query to prefetch the text page, so that we get fewer loaders

Use StudioButton instead of Button

Language fixes

  • Fjern -> Slett
  • Rediger -> Endre
@ErlingHauan ErlingHauan added status/ready-for-dev Status: Used for issues that are ready for development. Has been through grooming. kind/chore labels Jun 27, 2024
@ErlingHauan ErlingHauan moved this to 📈 Todo in Team Studio Jul 1, 2024
@ErlingHauan ErlingHauan removed the status in Team Studio Jul 1, 2024
@framitdavid
Copy link
Collaborator

@ErlingHauan what do you think of adding support for prefetching as well using tanstack-query? Then we got fewer loaders, but we still need to fix the UI glitches. 😊

@ErlingHauan
Copy link
Contributor Author

@framitdavid good idea, lets include that in this issue as well 😊

@wrt95 wrt95 moved this to 📈 Todo in Team Studio Jul 3, 2024
@ErlingHauan ErlingHauan self-assigned this Jul 4, 2024
@ErlingHauan ErlingHauan moved this from 📈 Todo to 👷 In Progress in Team Studio Jul 4, 2024
@ErlingHauan ErlingHauan moved this from 👷 In Progress to 🔎 Review in Team Studio Jul 16, 2024
@ErlingHauan ErlingHauan removed their assignment Jul 16, 2024
@ErlingHauan ErlingHauan linked a pull request Jul 16, 2024 that will close this issue
3 tasks
@ErlingHauan ErlingHauan assigned wrt95 and unassigned ErlingHauan Jul 16, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Studio Jul 17, 2024
@JamalAlabdullah JamalAlabdullah self-assigned this Jul 17, 2024
@JamalAlabdullah JamalAlabdullah moved this from 🧪 Test to ✅ Done in Team Studio Jul 17, 2024
@JamalAlabdullah JamalAlabdullah removed their assignment Jul 17, 2024
@JamalAlabdullah
Copy link
Contributor

tested ok in dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore status/ready-for-dev Status: Used for issues that are ready for development. Has been through grooming.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants