-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve loading of apps and data models on Dashboard #13137
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13137 +/- ##
==========================================
+ Coverage 92.16% 97.29% +5.13%
==========================================
Files 1443 13 -1430
Lines 20302 259 -20043
Branches 2432 46 -2386
==========================================
- Hits 18711 252 -18459
+ Misses 1326 5 -1321
+ Partials 265 2 -263 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 🚀
Added some comments 😄
...studio-components/src/components/StudioTableRemotePagination/StudioTableRemotePagination.tsx
Outdated
Show resolved
Hide resolved
...studio-components/src/components/StudioTableRemotePagination/StudioTableRemotePagination.tsx
Show resolved
Hide resolved
…om/Altinn/altinn-studio into fix/dashboard-table-spinner-height
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Description
This PR improves the loading of apps and datamodels on the Dashboard page.
spinnerHeight
state is set. This prevents flickering when loading uncached repos.isLoading
prop has been added toStudioTableRemotePagination
andStudioTableLocalPagination
. By using this prop,StudioSpinner
will be used internally with the correct height.Button
withStudioButton
in theRepoList
component, so that we have more control over changes coming from Designsystemet.RepoList
component, after guidelines posted by @Ildest on Slack. Also removed thedashboard.edit_data_models
text, since it was identical todashboard:edit_app
.Before this fix:
Screen.Recording.2024-06-27.at.10.28.10.mov
After fixing the spinner height:
smootherLoading.mp4
After adding prefetching:
afterPrefetching.mp4
Related Issue(s)
Verification