Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation issues when creating a new model #13364

Closed
Tracked by #10766
mlqn opened this issue Aug 14, 2024 · 1 comment · Fixed by #14049
Closed
Tracked by #10766

Validation issues when creating a new model #13364

mlqn opened this issue Aug 14, 2024 · 1 comment · Fixed by #14049
Labels
added-to-sprint area/data-modeling Area: Related to data models - e.g. create, edit, use data models. kind/chore status/triage team/studio-domain1

Comments

@mlqn
Copy link
Contributor

mlqn commented Aug 14, 2024

Description of the bug

1. The regex allows invalid formats

Entering a. or (space) as a name is valid on the frontend but invalid on the backend.

regex.mov

2. The error message does not reflect the regex

Entering 1a as a name is considered as invalid but it's not reflected in the error message

1a.mov

3. The required message is missing

Entering an empty name should display a different message indicating that the name is required, similar to the message shown when trying to enter an empty name while creating an app.

Data model validation (withtout required error message) App validation (with required error message)
required.mov
creating-app.mov

4. The error message is not cleared

When you close and reopen the dialog, the input text is cleared, but the old error message is still visible.

5. The input field is not focused

The input field should be focused when the creation dialog opens

6. Max length missing

A maxLength is missing on the input field, allowing long names that causes a backend error

max-length.mov
@mlqn mlqn added kind/bug Used when there is a defect / something is not working as it should. status/triage labels Aug 14, 2024
@mlqn mlqn added the area/data-modeling Area: Related to data models - e.g. create, edit, use data models. label Aug 14, 2024
@mlqn mlqn changed the title Issues with validation rules when creating a new model Validation issues when creating a new model Aug 14, 2024
@nkylstad nkylstad added kind/chore and removed kind/bug Used when there is a defect / something is not working as it should. labels Sep 23, 2024
@standeren standeren mentioned this issue Sep 26, 2024
3 tasks
@ErlingHauan ErlingHauan moved this to 📈 Todo in Team Studio Nov 8, 2024
@ErlingHauan ErlingHauan self-assigned this Nov 11, 2024
@ErlingHauan ErlingHauan moved this from 📈 Todo to 👷 In Progress in Team Studio Nov 11, 2024
@ErlingHauan ErlingHauan linked a pull request Nov 13, 2024 that will close this issue
3 tasks
@ErlingHauan ErlingHauan moved this from 👷 In Progress to 🔎 Review in Team Studio Nov 14, 2024
@ErlingHauan ErlingHauan removed their assignment Nov 14, 2024
@standeren standeren assigned standeren and ErlingHauan and unassigned standeren Nov 14, 2024
@ErlingHauan ErlingHauan assigned standeren and unassigned ErlingHauan Nov 18, 2024
@standeren standeren assigned ErlingHauan and unassigned standeren Nov 19, 2024
@ErlingHauan ErlingHauan assigned standeren and unassigned ErlingHauan Nov 19, 2024
@standeren standeren assigned ErlingHauan and unassigned standeren Nov 22, 2024
@ErlingHauan ErlingHauan moved this from 🔎 Review to 🧪 Test in Team Studio Nov 26, 2024
@Konrad-Simso Konrad-Simso moved this from 🧪 Test to 👷 In Progress in Team Studio Nov 28, 2024
@ErlingHauan ErlingHauan moved this from 👷 In Progress to 🧪 Test in Team Studio Dec 2, 2024
@ErlingHauan ErlingHauan removed their assignment Dec 2, 2024
@JamalAlabdullah
Copy link
Contributor

Tested Ok in dev 👍

@github-project-automation github-project-automation bot moved this from 🧪 Test to Documentation in Team Studio Dec 5, 2024
@ErlingHauan ErlingHauan moved this from Documentation to ✅ Done in Team Studio Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint area/data-modeling Area: Related to data models - e.g. create, edit, use data models. kind/chore status/triage team/studio-domain1
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

5 participants