-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing text #13629
fix: add missing text #13629
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13629 +/- ##
==========================================
- Coverage 94.30% 94.30% -0.01%
==========================================
Files 1534 1534
Lines 20899 20898 -1
Branches 2515 2515
==========================================
- Hits 19709 19708 -1
Misses 945 945
Partials 245 245 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bra jobba🙂
50362cc
to
92e44a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK with valid and invalid names
Description
Actually, this error message is not sufficient. We should use the same text as when creating a new model:
"schema_editor.invalid_datamodel_upload_filename": "Filnavnet er ugyldig. Du kan bruke tall og store og små bokstaver fra det norske alfabetet, og understrek, punktum og bindestrek.",
But this message is too long to be in a toast.The best solution for handling this error, invalid name error, is to show an error somewhere near the
Last opp
button that the user can close, or that closes by itself when triggering another event.However, the easiest solution with no more code than necessary is using a native alert:
Also added to the error message that the filename must start with a letter which the RegEx limits, but was not reflected in the original error message. See issue
Related Issue(s)
Verification