Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11177 move sidegrupper to dropdownselect #11245

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

JamalAlabdullah
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah commented Sep 27, 2023

Description

  • Added dropdown menu for pages group in the left menu in "Lage" page, It will be shown just when we have a page group.

Related Issue(s)

Verification

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@JamalAlabdullah JamalAlabdullah linked an issue Sep 27, 2023 that may be closed by this pull request
3 tasks
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7639ea5) 80.64% compared to head (7c469e4) 80.88%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11245      +/-   ##
==========================================
+ Coverage   80.64%   80.88%   +0.24%     
==========================================
  Files         738      738              
  Lines       11716    11717       +1     
  Branches     1556     1554       -2     
==========================================
+ Hits         9448     9477      +29     
+ Misses       2021     1992      -29     
- Partials      247      248       +1     
Files Coverage Δ
...or/src/components/leftMenu/LayoutSetsContainer.tsx 100.00% <100.00%> (ø)
...ges/ux-editor/src/components/leftMenu/LeftMenu.tsx 77.55% <0.00%> (+1.55%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette er en god start. Se kommentarer.

Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bra jobbet! Har du fått til å kjøre alle Cypress-testene? Vi har en fiks på en av dem på vei, foreslår at vi venter til den er ute og verifiserer at testene går grønt da.

@JamalAlabdullah JamalAlabdullah enabled auto-merge (squash) October 2, 2023 09:51
@JamalAlabdullah JamalAlabdullah merged commit 90ea373 into master Oct 2, 2023
@JamalAlabdullah JamalAlabdullah deleted the 11177-move-sidegrupper-to-dropdownselect branch October 2, 2023 12:34
nkylstad pushed a commit that referenced this pull request Oct 4, 2023
* Added dropdown list in left menu
nkylstad added a commit that referenced this pull request Oct 12, 2023
* Add titles and helpTexts to components (#11263)

* remove unused import & update test

* Apply suggestions from code review

Co-authored-by: andreastanderen <71079896+standeren@users.noreply.github.com>

* Make varaiblename- and variable-usage in cypress tests consistent (#11243)

* Make varaiblename- and variable-usage in cypress tests consistent

* Removed unused value in local cypress config file

* Use same usernames for dev and prod test users as before

* Use same usernames for staging test users as before

* remove invalid properties (#11257)

* remove invalid properties

* use correct property name in test

* Base successfully added expression on the expression property (#11250)

* Base successfully added expression on the property

* Eliminate the need to provide index in DragAndDrop (#11252)

* 11177 move sidegrupper to dropdownselect (#11245)

* Added dropdown list in left menu

* Replace LegacyCheckbox with Switch (#11244)

* Replace LegacyCheckbox with Switch

* Fix Switch errors

* Remove duplicate labels

* Replace LegacyCheckbox with Switch

* refactor: use context class (#11264)

* Context classes added

* Used context class in AppDevelopmentController

* Rename context generator method

* use context class in datamodelign controller

* use new context class in process modelling

* Add cancellation tokens

* format

* Delete unused methods from RepositorySI

* remove unused methods

* More unused methods

* repositorySi more unused

* Some repositorySi mehods migrated to use context

* CodeQl fix

* Add preview column (#11240)

* Update nb.json (#11268)

Fix typo

* Drag and drop tree view (#11270)

* updated tests

* added text resource binding

* merge issues

* sorting keys

* fix test

---------

Co-authored-by: andreastanderen <71079896+standeren@users.noreply.github.com>
Co-authored-by: Tomas Engebretsen <tomas.engebretsen@digdir.no>
Co-authored-by: JamalAlabdullah <90609090+JamalAlabdullah@users.noreply.github.com>
Co-authored-by: Michael Queyrichon <michael.queyrichon@digdir.no>
Co-authored-by: Mirko Sekulic <misha.sekulic@gmail.com>
Co-authored-by: andreas-didriksen <75472603+andreas-didriksen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move sidegrupper to dropdown/select
2 participants