feat: process-modeling templates #11310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
solution/studio/designer
This was
linked to
issues
Oct 5, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }; | ||
| try | ||
| { | ||
| using XmlReader reader = XmlReader.Create(xmlStream, settings); |
Check warning
Code scanning / CodeQL
Missing XML validation
github-actions
bot
added
the
skip-releasenotes
mirkoSekulic
force-pushed
the
feat/app-version-11168
branch
from
80e36e5 to
6eab98e
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11310 +/- ##
=======================================
Coverage 81.11% 81.11%
=======================================
Files 771 771
Lines 12123 12123
Branches 1614 1614
=======================================
Hits 9834 9834
Misses 2042 2042
Partials 247 247 ☔ View full report in Codecov by Sentry. |
backend/tests/Designer.Tests/Controllers/ApiTests/DisagnerEndpointsTestsBase.cs
Fixed
Show fixed
Hide fixed
mirkoSekulic
force-pushed
the
feat/app-version-11168
branch
from
545944f to
e86147d
Compare
github-actions
bot
removed
the
skip-releasenotes
framitdavid
reviewed
Oct 6, 2023
framitdavid
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
LGTM! 😊 Maybe @standeren should cross-check my review, since she knows more about the backend than I do.
I will do more backend reviews to familiarise myself with the backend. 😊
standeren
approved these changes
Oct 6, 2023
backend/src/Designer/Infrastructure/GitRepository/AltinnAppGitRepository.cs
Show resolved
Hide resolved
...rvices/Implementation/ProcessModeling/Templates/v8/start-data-confirmation-feedback-end.bpmn
Outdated
Show resolved
Hide resolved
backend/src/Designer/Services/Interfaces/IProcessModelingService.cs
Outdated
Show resolved
Hide resolved
backend/src/Designer/Services/Implementation/ProcessModeling/ProcessModelingService.cs
Show resolved
Hide resolved
...signer.Tests/Controllers/ProcessModelingController/SaveProcessDefinitionFromTemplateTests.cs
Show resolved
Hide resolved
mirkoSekulic
force-pushed
the
feat/app-version-11168
branch
from
e76be53 to
6a1e02b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ProcessModeling endpoints changed to use streaming instead of loading whole file in memory.
Added endpoints for app version and process-modeling templates
Related Issue(s)
Verification
Documentation