Avoid trying to add deleted files in zip when downloading changes #11992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
solution/studio/designer
…zip file when downloading changes
standeren
force-pushed
the
11385-downloading-diff-doesnt-work
branch
from
aadfbda to
5388c33
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mirkoSekulic
requested changes
Jan 12, 2024
mirkoSekulic
approved these changes
Jan 12, 2024
standeren
force-pushed
the
11385-downloading-diff-doesnt-work
branch
from
6850c6f to
fff397c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check for FileStatus deleted before trying to add the content to the zip file when downloading changes.
This will only fix the error but we wont be able to actually present what files the app-developer has deleted.
How we should represent that for the app-dev must be discussed more before implementation. A new issue will be created for that.
Related Issue(s)
Verification