-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/drag preview bug on group with hidden children #12164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
label
Jan 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12164 +/- ##
=======================================
Coverage 87.98% 87.98%
=======================================
Files 981 981
Lines 14077 14077
Branches 1714 1714
=======================================
Hits 12386 12386
- Misses 1480 1481 +1
+ Partials 211 210 -1 ☔ View full report in Codecov by Sentry. |
lassopicasso
added
the
kind/bug
Used when there is a defect / something is not working as it should.
label
Jan 26, 2024
ghost
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/bug
Used when there is a defect / something is not working as it should.
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bug causes an incorrect visual representation of a group of elements that is hidden in a drag preview. It seems like it is related to Chrome since it happens on other frameworks beside dnd as well but works fine in Firefox. Maybe the ripple effect. In Material-UI, disabling the ripple can fix it.
In our case setting the translate(0) on the container also solves the issue.
Wrong dragPreview in Chrome
Related Issue(s)
Verification
Documentation