Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/drag preview bug on group with hidden children #12164

Merged
merged 7 commits into from
Jan 29, 2024

Conversation

lassopicasso
Copy link
Contributor

@lassopicasso lassopicasso commented Jan 26, 2024

Description

This bug causes an incorrect visual representation of a group of elements that is hidden in a drag preview. It seems like it is related to Chrome since it happens on other frameworks beside dnd as well but works fine in Firefox. Maybe the ripple effect. In Material-UI, disabling the ripple can fix it.
In our case setting the translate(0) on the container also solves the issue.

Wrong dragPreview in Chrome

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Jan 26, 2024
@lassopicasso lassopicasso linked an issue Jan 26, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2dd32f7) 87.98% compared to head (b1fc4a0) 87.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12164   +/-   ##
=======================================
  Coverage   87.98%   87.98%           
=======================================
  Files         981      981           
  Lines       14077    14077           
  Branches     1714     1714           
=======================================
  Hits        12386    12386           
- Misses       1480     1481    +1     
+ Partials      211      210    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lassopicasso lassopicasso added the kind/bug Used when there is a defect / something is not working as it should. label Jan 26, 2024
@lassopicasso lassopicasso marked this pull request as ready for review January 26, 2024 14:16
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM😄

@lassopicasso lassopicasso merged commit ba7886c into main Jan 29, 2024
12 checks passed
@lassopicasso lassopicasso deleted the drag-and-drop-shadow branch January 29, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Used when there is a defect / something is not working as it should. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Odd behaviour in drag-n-drop with closed parent item
1 participant