-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/12153 component schema v4 update #12351
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #12351 +/- ##
==========================================
+ Coverage 86.69% 86.70% +0.01%
==========================================
Files 1198 1198
Lines 18050 18067 +17
Branches 2288 2290 +2
==========================================
+ Hits 15648 15665 +17
- Misses 2120 2121 +1
+ Partials 282 281 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments and suggestions to consider, but looks very good 🌟
Also one additional general comment; would it make sense to create an enum for all the propertytypes? They are repeated many times in both tests, rendercode and methods so might be safer to use an enum? 🫣
frontend/packages/ux-editor/src/components/config/FormComponentConfig.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/config/FormComponentConfig.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/config/FormComponentConfig.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/config/FormComponentConfig.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/config/FormComponentConfig.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/config/FormComponentConfig.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean 🥇
Two comments only 😬
frontend/packages/ux-editor/src/components/config/FormComponentConfig.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: andreastanderen <71079896+standeren@users.noreply.github.com>
Description
Some changes and updates after testing comments.
type: "string"
for objects withenum
and included updated schemas after running scriptas this results in a cleaner view overall. See screenshot.
Related Issue(s)
Verification
Documentation