Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/12153 component schema v4 update #12351

Merged
merged 13 commits into from
Feb 22, 2024

Conversation

nkylstad
Copy link
Member

Description

Some changes and updates after testing comments.

  • Added back support for object property types
    • Specified that only object properties with specified properties are supported
  • Specified that only array property types with enums are supported
  • Removed component type heading from beta view
  • Updated script to ensure type: "string" for objects with enum and included updated schemas after running script
  • Sorted component config properties by:
    • Grid
    • Boolean (incl. expression types)
    • String/number/enum array (incl. expression types)
    • Objects
      as this results in a cleaner view overall. See screenshot.
      Screenshot 2024-02-20 at 15 44 55

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Feb 20, 2024
@standeren standeren self-assigned this Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4f0a8b0) 86.69% compared to head (10c824d) 86.70%.

Files Patch % Lines
...itor/src/components/config/FormComponentConfig.tsx 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12351      +/-   ##
==========================================
+ Coverage   86.69%   86.70%   +0.01%     
==========================================
  Files        1198     1198              
  Lines       18050    18067      +17     
  Branches     2288     2290       +2     
==========================================
+ Hits        15648    15665      +17     
- Misses       2120     2121       +1     
+ Partials      282      281       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments and suggestions to consider, but looks very good 🌟

Also one additional general comment; would it make sense to create an enum for all the propertytypes? They are repeated many times in both tests, rendercode and methods so might be safer to use an enum? 🫣

@nkylstad nkylstad requested a review from standeren February 21, 2024 14:31
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean 🥇
Two comments only 😬

nkylstad and others added 2 commits February 22, 2024 09:45
Co-authored-by: andreastanderen <71079896+standeren@users.noreply.github.com>
@nkylstad nkylstad merged commit 456e042 into main Feb 22, 2024
11 checks passed
@nkylstad nkylstad deleted the chore/12153-component-schema-v4-update branch February 22, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants