Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12189 remove i18next from studio components #12354

Merged
10 commits merged into from
Feb 22, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 21, 2024

Description

  • Removing i18next from the @studio/components folder.
  • Adding unique texts for loading spinners and close modal buttons.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@ghost ghost linked an issue Feb 21, 2024 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. area/dashboard Area: Related to the dashboard application area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. area/text-editor area/studio-root Area: Issues related to studio-root application labels Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4f0a8b0) 86.69% compared to head (78e214f) 86.68%.

Files Patch % Lines
...es/appPublish/components/deploy/DeployDropdown.tsx 0.00% 1 Missing ⚠️
...evelopment/features/simpleMerge/ResetRepoModal.tsx 0.00% 0 Missing and 1 partial ⚠️
...components/StudioPageSpinner/StudioPageSpinner.tsx 0.00% 1 Missing ⚠️
...tor-v3/src/components/config/EditFormComponent.tsx 0.00% 0 Missing and 1 partial ⚠️
...editor/src/components/config/EditFormComponent.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12354      +/-   ##
==========================================
- Coverage   86.69%   86.68%   -0.01%     
==========================================
  Files        1198     1200       +2     
  Lines       18050    18053       +3     
  Branches     2288     2288              
==========================================
+ Hits        15648    15650       +2     
- Misses       2120     2121       +1     
  Partials      282      282              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here! Should we take the opportunity to increase test coverage in areas that are not tested here? 😊 It would also help with housekeeping. 👏

@ghost ghost merged commit 16392d3 into main Feb 22, 2024
10 of 11 checks passed
@ghost ghost deleted the 12189-remove-i18next-from-studio-components branch February 22, 2024 09:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. area/dashboard Area: Related to the dashboard application area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/studio-root Area: Issues related to studio-root application area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependencies on I18next from the components package
2 participants