Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the broken and flaky playwright tests #12360

Merged
2 commits merged into from
Feb 21, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 21, 2024

Description

  • Adding waits for correct elements on data model page to ensure the upload and creation of data models are done correctly. This might solve the flaky tests on data model page.

Related Issue(s)

  • This PR

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. labels Feb 21, 2024
@lassopicasso lassopicasso self-assigned this Feb 21, 2024
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@lassopicasso lassopicasso assigned ghost and unassigned lassopicasso Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5be613e) 86.63% compared to head (7519800) 86.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12360   +/-   ##
=======================================
  Coverage   86.63%   86.63%           
=======================================
  Files        1199     1199           
  Lines       18054    18054           
  Branches     2286     2286           
=======================================
  Hits        15641    15641           
  Misses       2129     2129           
  Partials      284      284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost ghost merged commit 164a38a into main Feb 21, 2024
11 checks passed
@ghost ghost deleted the fix-boken-and-flaky-playwright-tests branch February 21, 2024 12:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants