Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate namespace for new models #12402

Merged
merged 2 commits into from
Feb 28, 2024
Merged

separate namespace for new models #12402

merged 2 commits into from
Feb 28, 2024

Conversation

mirkoSekulic
Copy link
Collaborator

@mirkoSekulic mirkoSekulic commented Feb 27, 2024

Description

Separate namepace for new models introduced.
If datamodel reference exists in application metadata, namespace stays unchanged.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Feb 27, 2024
@mirkoSekulic mirkoSekulic marked this pull request as draft February 27, 2024 08:00
@mirkoSekulic mirkoSekulic force-pushed the feature/model-namespace branch from d3cc0ea to c577a99 Compare February 27, 2024 08:04
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.73%. Comparing base (f90ec1b) to head (c577a99).
Report is 1 commits behind head on main.

❗ Current head c577a99 differs from pull request most recent head 6b82fa9. Consider uploading reports for the commit 6b82fa9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12402   +/-   ##
=======================================
  Coverage   86.73%   86.73%           
=======================================
  Files        1205     1205           
  Lines       18109    18109           
  Branches     2292     2292           
=======================================
+ Hits        15706    15707    +1     
+ Misses       2122     2121    -1     
  Partials      281      281           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Feb 27, 2024
@mirkoSekulic mirkoSekulic force-pushed the feature/model-namespace branch 5 times, most recently from d604f38 to fc0895f Compare February 27, 2024 13:36
@mirkoSekulic mirkoSekulic force-pushed the feature/model-namespace branch from fc0895f to 6b82fa9 Compare February 27, 2024 13:38
@mirkoSekulic mirkoSekulic linked an issue Feb 27, 2024 that may be closed by this pull request
4 tasks
@mirkoSekulic mirkoSekulic marked this pull request as ready for review February 27, 2024 13:48
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool ⭐

@mirkoSekulic mirkoSekulic merged commit 923b009 into main Feb 28, 2024
10 checks passed
@mirkoSekulic mirkoSekulic deleted the feature/model-namespace branch February 28, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure model name is used in namespace for model as suggested above
2 participants