-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/12320 update address component v4 #12405
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12405 +/- ##
=======================================
Coverage 87.11% 87.11%
=======================================
Files 1194 1194
Lines 17965 17965
Branches 2290 2290
=======================================
Hits 15651 15651
Misses 2033 2033
Partials 281 281 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🥳
Two things:
- TextKey in
nb.json
also needs to be updated;
"ux_editor.component_title.AddressComponent": "Adresse"
- Can the
AddressComponent.schema.v1.json
file be deleted?
Good catch! Updated now 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 1521 in nb.json
also needs to be updated 🤓
Or actually we might need to add both text keys (both title and helptext) for Address (v4) and AddressComponent (v3)?
Good point! I have updated in both places now 😊 |
Description
Updated
AddressComponent
toAddress
to match v4 config.Related Issue(s)
Verification