Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/12320 update address component v4 #12405

Merged
merged 8 commits into from
Feb 28, 2024

Conversation

nkylstad
Copy link
Member

Description

Updated AddressComponent to Address to match v4 config.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.11%. Comparing base (fb00671) to head (89d350e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12405   +/-   ##
=======================================
  Coverage   87.11%   87.11%           
=======================================
  Files        1194     1194           
  Lines       17965    17965           
  Branches     2290     2290           
=======================================
  Hits        15651    15651           
  Misses       2033     2033           
  Partials      281      281           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🥳

Two things:

  1. TextKey in nb.json also needs to be updated;

"ux_editor.component_title.AddressComponent": "Adresse"

  1. Can the AddressComponent.schema.v1.json file be deleted?

@nkylstad
Copy link
Member Author

  1. TextKey in nb.json also needs to be updated;

"ux_editor.component_title.AddressComponent": "Adresse"

  1. Can the AddressComponent.schema.v1.json file be deleted?

Good catch! Updated now 😊

Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 1521 in nb.json also needs to be updated 🤓

https://github.com/Altinn/altinn-studio/pull/12405/files#diff-3c337bd77f5ff70f1f68d29294960afca38ea082fe9b2716b109a46d89fdf8ddR1521

Or actually we might need to add both text keys (both title and helptext) for Address (v4) and AddressComponent (v3)?

@nkylstad
Copy link
Member Author

Or actually we might need to add both text keys (both title and helptext) for Address (v4) and AddressComponent (v3)?

Good point! I have updated in both places now 😊

@nkylstad nkylstad merged commit 3a3c9db into main Feb 28, 2024
10 checks passed
@nkylstad nkylstad deleted the chore/12320-update-address-component-v4 branch February 28, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants