Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch model metadata based on selected layoutset #12411

Merged

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Feb 28, 2024

Description

Use selectedLayoutSet in payload when fetching model metadata to get corresponding metadata for corresponding task in layoutsets-file

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@standeren standeren linked an issue Feb 28, 2024 that may be closed by this pull request
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Feb 28, 2024
@standeren standeren force-pushed the 12400-fetch-correct-data-model-based-on-selected-layout-set branch 3 times, most recently from 403a87c to 2f41fa9 Compare February 28, 2024 11:25
@github-actions github-actions bot added quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes labels Feb 28, 2024
@standeren standeren force-pushed the 12400-fetch-correct-data-model-based-on-selected-layout-set branch 3 times, most recently from 7942ed6 to b82bb87 Compare February 28, 2024 16:01
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.45%. Comparing base (57e33d0) to head (347660a).
Report is 15 commits behind head on main.

❗ Current head 347660a differs from pull request most recent head fd65f7d. Consider uploading reports for the commit fd65f7d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12411   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files        1270     1270           
  Lines       18450    18458    +8     
  Branches     2288     2288           
=======================================
+ Hits        16136    16143    +7     
- Misses       2040     2041    +1     
  Partials      274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren force-pushed the 12400-fetch-correct-data-model-based-on-selected-layout-set branch 5 times, most recently from d3ca15b to 8c6ad53 Compare March 1, 2024 12:34
@github-actions github-actions bot added the area/data-modeling Area: Related to data models - e.g. create, edit, use data models. label Mar 1, 2024
@standeren standeren force-pushed the 12400-fetch-correct-data-model-based-on-selected-layout-set branch 2 times, most recently from 31cab20 to d35e099 Compare March 1, 2024 13:20
@standeren standeren force-pushed the 12400-fetch-correct-data-model-based-on-selected-layout-set branch from d35e099 to b7e2517 Compare March 1, 2024 13:51
@standeren standeren force-pushed the 12400-fetch-correct-data-model-based-on-selected-layout-set branch from b7e2517 to 347660a Compare March 4, 2024 07:44
@standeren standeren merged commit d0e8cfe into main Mar 6, 2024
10 checks passed
@standeren standeren deleted the 12400-fetch-correct-data-model-based-on-selected-layout-set branch March 6, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch correct data model based on selected layout set
2 participants