Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property button component #12428

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Add property button component #12428

merged 3 commits into from
Mar 4, 2024

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Mar 1, 2024

Description

Added a component that can be used for these buttons:
image

I have also implemented it on the data model bindings:
https://github.com/Altinn/altinn-studio/assets/29770305/06a61dc3-da37-4941-a90c-b9119ac21c03

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Mar 1, 2024
@TomasEng TomasEng force-pushed the add-property-button-component branch from 5b3a1fc to 5f8b405 Compare March 1, 2024 12:42
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.46%. Comparing base (57e33d0) to head (f8e6346).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12428   +/-   ##
=======================================
  Coverage   87.45%   87.46%           
=======================================
  Files        1270     1272    +2     
  Lines       18450    18463   +13     
  Branches     2288     2291    +3     
=======================================
+ Hits        16136    16148   +12     
- Misses       2040     2041    +1     
  Partials      274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomasEng TomasEng marked this pull request as ready for review March 1, 2024 13:03
@standeren standeren self-assigned this Mar 4, 2024
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ⭐

@TomasEng TomasEng merged commit 27e4603 into main Mar 4, 2024
11 checks passed
@TomasEng TomasEng deleted the add-property-button-component branch March 4, 2024 08:45
standeren pushed a commit that referenced this pull request Mar 5, 2024
standeren pushed a commit that referenced this pull request Mar 5, 2024
standeren added a commit that referenced this pull request Mar 15, 2024
* Add page config panel

* Add tests

* Fix parallell tests issue

* Add test for navigationMenu in page accordion

* Adapt playwright tests

* Use variable from fds for min-height in StudioSectionHeader

---------

Co-authored-by: Tomas Engebretsen <tomas.engebretsen@digdir.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants