Not show required radiobuttons when using code list #12448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/ui-editor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12448 +/- ##
=======================================
Coverage 87.51% 87.51%
=======================================
Files 1274 1274
Lines 18496 18496
Branches 2293 2293
=======================================
Hits 16186 16186
Misses 2037 2037
Partials 273 273 ☔ View full report in Codecov by Sentry. |
standeren
deleted the
not-show-required-radiobuttons-when-using-code-list
branch
TomasEng
reviewed
Mar 12, 2024
| @@ -219,7 +219,9 @@ export function EditOptions<T extends SelectionComponentType>({ | |||
| </StudioButton> | |||
| </div> | |||
| )} | |||
| {errorMessage && <ErrorMessage size='small'>{errorMessage}</ErrorMessage>} | |||
| {selectedOptionsType !== SelectedOptionsType.CodeList && errorMessage && ( | |||
There was a problem hiding this comment.
Vi må kunne stole på at errorMessage er riktig her. Er det noen grunn til å ikke gjøre denne sjekken et annet sted, @standeren?
nkylstad
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Remove 'At least one radio required' error message when custom code list is enabled * Adapt tests for checkboxes also
nkylstad
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Remove 'At least one radio required' error message when custom code list is enabled * Adapt tests for checkboxes also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove error message that
At least one checkbox/radiobutton is requiredwhen custom code list is enabledVerification