Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Playwright): Fixed e2e-tests after v4 support #12464

Merged
merged 3 commits into from
Mar 7, 2024
Merged

fix(Playwright): Fixed e2e-tests after v4 support #12464

merged 3 commits into from
Mar 7, 2024
+54 −53

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Mar 7, 2024 •
edited
Loading

Description

Removed unnecessary methods and adjusted tests to align with the updated app folder structure (v4) and UI changes in Studio.

Related Issue(s)

  • PR itself.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. labels Mar 7, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.52%. Comparing base (8817b7d) to head (de5f6a3).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #12464   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files        1274     1274           
  Lines       18488    18488           
  Branches     2294     2294           
=======================================
  Hits        16182    16182           
  Misses       2032     2032           
  Partials      274      274

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@framitdavid framitdavid marked this pull request as ready for review March 7, 2024 20:04
@framitdavid framitdavid enabled auto-merge (squash) March 7, 2024 20:09
@framitdavid framitdavid added the skip-releasenotes Issues that do not make sense to list in our release notes label Mar 7, 2024
nkylstad
nkylstad approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@framitdavid framitdavid merged commit abcca17 into main Mar 7, 2024
10 checks passed
@framitdavid framitdavid deleted the fix/updateE2ETestsToMatchV4 branch March 7, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkylstad nkylstad nkylstad approved these changes

Assignees
No one assigned
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Team Studio
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@framitdavid @nkylstad