resourceadm bugfix: fix import resource identifier validation and return errors #12466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.Contains new identifier
github-actions
bot
added
the
solution/studio/designer
…efore trying to import policy file
github-actions
bot
added
the
quality/testing
mgunnerud
changed the title
…source-with-an-identifier-which-is-a-substring-of-existing-resource
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12466 +/- ##
=======================================
Coverage 88.10% 88.10%
=======================================
Files 1271 1271
Lines 18321 18321
Branches 2263 2263
=======================================
Hits 16141 16141
Misses 1910 1910
Partials 270 270 ☔ View full report in Codecov by Sentry. |
…source-with-an-identifier-which-is-a-substring-of-existing-resource
mgunnerud
deleted the
12461-resourceadm-cannot-create-or-import-resource-with-an-identifier-which-is-a-substring-of-existing-resource
branch
nkylstad
pushed a commit
that referenced
this pull request
Mar 13, 2024
…urn errors (#12466) * bugfix: equality check resource name with exact filename, not filename.Contains new identifier * bugfix: return error code if error happens when importing resource, before trying to import policy file
nkylstad
pushed a commit
that referenced
this pull request
Mar 13, 2024
…urn errors (#12466) * bugfix: equality check resource name with exact filename, not filename.Contains new identifier * bugfix: return error code if error happens when importing resource, before trying to import policy file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Verification
Documentation