Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configure layoutsets panel and adapt css on layoutsets dropdown #12472

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

standeren
Copy link
Contributor

Description

  • Delete configure layout sets panel as this convertion is provided through the upgrade script.

  • Remove the check for existing layoutsets in LayoutSetsContainer in v4 since all v4 apps will have the layoutsets file anyway.

  • Adapt css on layout sets container native select in order to be consistent in width undependant of the contnet in the select.

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Mar 8, 2024
@standeren standeren marked this pull request as ready for review March 8, 2024 12:47
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.10%. Comparing base (1163fa7) to head (609c9d8).

Files Patch % Lines
.../ux-editor-v3/src/components/Elements/Elements.tsx 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12472      +/-   ##
==========================================
+ Coverage   87.52%   88.10%   +0.57%     
==========================================
  Files        1274     1271       -3     
  Lines       18489    18321     -168     
  Branches     2294     2263      -31     
==========================================
- Hits        16183    16141      -42     
+ Misses       2032     1910     -122     
+ Partials      274      270       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 🚀

@standeren standeren merged commit 4f7ac24 into main Mar 8, 2024
10 of 11 checks passed
@standeren standeren deleted the delete-configure-layout-set branch March 8, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants