Validate Unique ID for All Layouts in a Layout-Set #12487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/ui-editor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12487 +/- ##
==========================================
- Coverage 88.14% 88.12% -0.03%
==========================================
Files 1287 1271 -16
Lines 18364 18324 -40
Branches 2253 2266 +13
==========================================
- Hits 16187 16148 -39
- Misses 1905 1909 +4
+ Partials 272 267 -5 ☔ View full report in Codecov by Sentry. |
lassopicasso
changed the title
TomasEng
reviewed
Mar 14, 2024
Comment on lines
+119
to
+132
| export function idExists(id: string, formLayouts: IFormLayouts): boolean { | ||
| return Object.values(formLayouts).some((layout) => { | ||
| const idMatchesContainers = | ||
| Object.keys(layout.containers || {}).findIndex( | ||
| (key) => key.toUpperCase() === id.toUpperCase(), | ||
| ) > -1; | ||
| const idMatchesComponents = | ||
| Object.keys(layout.components || {}).findIndex( | ||
| (key) => key.toUpperCase() === id.toUpperCase(), | ||
| ) > -1; | ||
|
|
||
| return idMatchesContainers || idMatchesComponents; | ||
| }); | ||
| } |
There was a problem hiding this comment.
Her kan vi også bruke some i stedet for findIndex. Men ville det ikke vært ryddigere å beholde den gamle idExists og referere til den her?
export function idExists(id: string, formLayouts: IFormLayouts): boolean {
return Object.values(formLayouts).some((layout) => idExistsInLayout(id, layout));
}
There was a problem hiding this comment.
Det var et godt forslag! Jeg skal fikse det
4 tasks
lassopicasso
added a commit
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored
idExistsvalidation to support multiple layouts. The unique ID rule now considers all layouts within a layout-set.Related Issue(s)
Verification
Documentation