Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling of changed receipt name #12560

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Mar 20, 2024

Description

  • Remove unnecessary try/catch, throw errors
  • Fix typos and docs
  • Add error handling in frontend
Skjermopptak.2024-03-21.kl.10.38.35.mov

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. labels Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 96.36364% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.69%. Comparing base (cb2f905) to head (5edfa06).

Files Patch % Lines
...ges/process-editor/src/contexts/BpmnApiContext.tsx 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12560      +/-   ##
==========================================
+ Coverage   88.67%   88.69%   +0.01%     
==========================================
  Files        1288     1288              
  Lines       18513    18533      +20     
  Branches     2265     2270       +5     
==========================================
+ Hits        16417    16437      +20     
- Misses       1835     1836       +1     
+ Partials      261      260       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren force-pushed the remove-catch-if-layoutset-not-found branch 3 times, most recently from eba905d to 540ee15 Compare March 20, 2024 13:32
@standeren standeren marked this pull request as draft March 20, 2024 14:33
@standeren standeren changed the title Clean up appDev controller and service Clean up appDev controller and service and add better error handling of changed receipt name Mar 20, 2024
@standeren standeren marked this pull request as ready for review March 21, 2024 11:18
@standeren standeren changed the title Clean up appDev controller and service and add better error handling of changed receipt name Add error handling of changed receipt name Mar 21, 2024
@standeren standeren force-pushed the remove-catch-if-layoutset-not-found branch 3 times, most recently from e1e5288 to 6cc0ca5 Compare March 21, 2024 12:24
@standeren standeren linked an issue Mar 21, 2024 that may be closed by this pull request
@framitdavid
Copy link
Collaborator

framitdavid commented Mar 26, 2024

Description

  • Remove unnecessary try/catch, throw errors
  • Fix typos and docs
  • Add error handling in frontend

Skjermopptak.2024-03-21.kl.10.38.35.mov

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Er det noen grunn til at ikonet og feilmeldingen hopper og ikke er alignet? Når jeg ser på lage-siden, så hopper ikke ikonet når det kommer feilmelding. Ikonet er også riktig sentrert.

image

@standeren
Copy link
Contributor Author

standeren commented Mar 27, 2024

Description

  • Remove unnecessary try/catch, throw errors
  • Fix typos and docs
  • Add error handling in frontend

Skjermopptak.2024-03-21.kl.10.38.35.mov

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Er det noen grunn til at ikonet og feilmeldingen hopper og ikke er alignet? Når jeg ser på lage-siden, så hopper ikke ikonet når det kommer feilmelding. Ikonet er også riktig sentrert.

image

Det ser ut som det skyltes en manglende label. Jeg la den til nå og da hopper det ikke lenger, men da ser det litt rotete ut med tekstene 🤔 Denne delen mangler jo for øvrig skisser fullstendig så det må uansett gjøres et ekstra løft på det senere. Tenker uansett det er greit at det funksjonelle kommer på plass nå i første omgang 😬

Skjermopptak.2024-03-27.kl.12.28.28.mov

Her er forresten saken der design diskuteres 🥳

@standeren standeren force-pushed the remove-catch-if-layoutset-not-found branch 3 times, most recently from 16af1cd to e313ac6 Compare April 2, 2024 10:53
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just one small comment, you can consider if you want to change it or not. 🚀

frontend/language/src/nb.json Show resolved Hide resolved
@standeren standeren force-pushed the remove-catch-if-layoutset-not-found branch from e313ac6 to 5edfa06 Compare April 4, 2024 09:01
@standeren standeren merged commit bbce0ca into main Apr 4, 2024
17 checks passed
@standeren standeren deleted the remove-catch-if-layoutset-not-found branch April 4, 2024 10:05
Jondyr pushed a commit that referenced this pull request Jun 10, 2024
* Refactor

* Add BpmnApiContext with queryresults and mutation callbacks

* Fix bouncing input field when error message is visible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new endpoint for adding receipt as a layoutset
2 participants