Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PaymentTask): Integrate Altinn Payment Task into ProcessEditor #12562

Merged
merged 7 commits into from
Mar 21, 2024

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Mar 20, 2024

Description

I have made many attempts to drag and drop elements into the process editor using Playwright and can see that the element is being dropped correctly step by step, but unfortunately, the task itself is not being added to the diagram. When I test with actual drag and drop in the browser, it works as expected. I would appreciate any good suggestions if anyone has them. 😊

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Mar 20, 2024
@framitdavid framitdavid linked an issue Mar 20, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 88.13%. Comparing base (4361ad6) to head (f0d6dfa).
Report is 2 commits behind head on main.

Files Patch % Lines
...itor/src/bpmnProviders/SupportedPaletteProvider.js 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12562      +/-   ##
==========================================
- Coverage   88.15%   88.13%   -0.03%     
==========================================
  Files        1293     1293              
  Lines       18487    18494       +7     
  Branches     2265     2265              
==========================================
+ Hits        16297    16299       +2     
- Misses       1924     1929       +5     
  Partials      266      266              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just remove the console.log :)
Unfortunately, I have no suggestions regarding testing the drag and drop with Playwright. Perhaps you want to keep this under review in case others have any suggestions.

frontend/packages/shared/src/utils/featureToggleUtils.ts Outdated Show resolved Hide resolved
@framitdavid framitdavid merged commit 6672dc5 into main Mar 21, 2024
8 of 10 checks passed
@framitdavid framitdavid deleted the feat/addPaymentTaskToBpmnEditor branch March 21, 2024 13:40
standeren pushed a commit that referenced this pull request Mar 25, 2024
…12562)

* feat(PaymentTask): added Altinn Payment Task to Editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new task named Payment within BPMN-editor.
2 participants