Make sure selectedLayoutSet is an existing one in layoutsets before rendering ux-editor #12566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/ui-editor
standeren
force-pushed
the
set-initial-layoutset-to-an-existing
branch
3 times, most recently
from
bd28f70 to
3db11cb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12566 +/- ##
==========================================
+ Coverage 88.67% 88.68% +0.01%
==========================================
Files 1288 1288
Lines 18513 18514 +1
Branches 2265 2265
==========================================
+ Hits 16417 16420 +3
+ Misses 1835 1834 -1
+ Partials 261 260 -1 ☔ View full report in Codecov by Sentry. |
standeren
force-pushed
the
set-initial-layoutset-to-an-existing
branch
from
3db11cb to
83a73a8
Compare
Jondyr
pushed a commit
that referenced
this pull request
Jun 10, 2024
…endering ux-editor (#12566) * Make sure selectedLayout is an existing one in layoutsets before rendering ux-editor * Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If editing a page in a layoutset that has been deleted we get error in ux-editor.
It can be tested by adding a custom receipt (or any other new layout set in teory), go to app-dev page, and back to process and delete local changes. Going to app-dev page again will result in errors.
This PR updates the selected layout set to the first in the set if the currently selected one does not exist. OBS: only possible to do this change for v4 since these apps require layoutsets.
Related Issue(s)
Verification